Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

• feat: bulk delete documents in nova app #777 👈 (View in Graphite)
• main

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

can select & delete button can be at the right of dismiss?

can select & delete button can be at the right of dismiss?

​what do you mean @Prasanna721 i didn't get it

Claude finished @MaheshtheDev's task in 1m 9s —— View job

Tasks

• Analyze PR changes for bugs and security issues
• Verify if the Sentry-flagged bug has been addressed
• Check for any other issues in the bulk delete implementation
• Provide final review summary

Overview: Adds bulk delete functionality for documents with selection mode UI, optimistic updates, and confirmation dialog.

Issues found: None — the Sentry-flagged bug has been fixed in the current code.

The previous review identified a bug where bulkDeleteMutation.onSuccess was calling onClose?.(), which would reset the quick note draft. Looking at the current code at apps/web/hooks/use-document-mutations.ts:546-552:

onSuccess: (_data, variables) => {
    analytics.documentsBulkDeleted({ count: variables.documentIds.length })
    toast.success(
        `${variables.documentIds.length} document${variables.documentIds.length === 1 ? "" : "s"} deleted`,
    )
    queryClient.invalidateQueries({ queryKey: ["documents-with-memories"] })
},

The onClose?.() call is correctly not present in bulkDeleteMutation, unlike the single deleteMutation which still calls it (appropriate for that use case). The fix has already been applied.

Score: 9/10

Well-implemented feature with proper:

• Server-side validation (max 100 IDs)
• Optimistic updates with rollback on error
• Confirmation dialog before destructive action
• Proper selection state management
• Analytics tracking

can select & delete button can be at the right of dismiss?

​what do you mean @Prasanna721 i didn't get it

instead if pushing the layout down and showing the select all and delete button...

we can just use the space right of dismiss button to select all and delete​, we can use the real estate?

Merge activity

• Mar 10, 3:28 PM UTC: MaheshtheDev added this pull request to the Graphite merge queue.
• Mar 10, 3:30 PM UTC: Merged by the Graphite merge queue.